search

onflow / kitty-items

Kitty Items: CryptoKitties Sample App
https://kitty-items.onflow.org
Apache License 2.0
409 stars 214 forks source link

Change KittyItems to support secure cadence and implement Metadata standard #245

Closed bshahid331 closed 2 years ago

bshahid331 commented 2 years ago

Summary

This repo is something is great for learning! It should implement the changes required for Secure Cadence and the NFT Standard so more people will implement their NFTs correctly.

I installed the Secure Cadence version of Flow and updated the contract to adhere to it.

Test Plan Ran the JS test suite and confirmed everything passes. Please let me know if I missed anything.

Screen Shot 2022-05-17 at 9 45 21 AM

NOTE: The build doesn't use the most up to date flow version. I can change this too but left it out for now.

bluesign commented 2 years ago

@10thfloor This breaks current testnet deploy no ?