Support custom transactions

[bluesign]

Currently with FCL ledger is not much usable, I think supporting custom transactions would benefit the ecosystem much.

It should be pretty easy to implement and makes ledger more useful with flow.

[pgebheim]

The main reason we haven't been able to do this is because of the requirements from LedgerHQ.

https://developers.ledger.com/docs/nano-app/secure-app/#avoid-blindly-signing-data

[bluesign]

@pgebheim We discussed this with you many times, but as you gave example to LedgerHQ once again. Kraken awakens

This is totally, 100%, without doubt on Flow Team. I am not saying LedgerHQ didn't reject your ideas etc, I am just saying that there is a big lack of motivation on this issue.

Now you linked me some URL from LedgerHQ. ( to be fair I don't recall if I checked before, but now once again I went there, read it all, luckily I read fast )

Then there is: https://developers.ledger.com/docs/nano-app/secure-app/#application-architecture

It says:

The Solana app is a great example of such architecture. We recommend developing a portable library implementing all the complex steps of the signature flow (parsing, field selection and field formatting) as he libsol library from Solana does.

I got curious, clicked the solana app link to see what they did:

https://github.com/LedgerHQ/app-solana#overview

Now I am pasting here for the lazy: ( made bold also )

This app adds support for the Solana native token to Ledger Nano S hardware wallet.

Current Features:

Pubkey queries Parse, display and sign all Solana CLI generated transaction formats Blind sign arbitrary transactions (Enabled via settings)

I am sorry but if you cannot make this feature in to the ledger app, which is the example of best practice, in the document you shared ( from ledgerHQ) ( oh btw you are working at the company lobbying world governments for NFT license standard [ https://github.com/onflow/flow-nft/issues/106 ])

I think this is so absurd can be a monty python episode.

[pgebheim]

My latest conversation about this with @Wolog2021 is that I believe we should work on adding "sign arbitrary transactions" as a setting + getting approval from ledger to approve the app.

Also we should work on adding support for better human readable transactions support even if that feature is available.

[pgebheim]

Noting that #98 is relevant here.

If this works then I'd consider this ticket to be closable by that.

[cybercent]

Any progress here ? We're looking to integrate Ledger with Flow non-custodial browser wallets.

Edit: It looks like @pgebheim is with Polygon now.