search

onflow / ledger-app-flow

Apache License 2.0
10 stars 12 forks source link

Return to 1a433d45, bump version #62

Closed relatko closed 3 years ago

relatko commented 3 years ago

@tarakby Thanks for identifying the refactors we want to keep. I prefer to do it in another commit. The idea is to make the review process trivial for ledger guys (they review against 0.9.10, and they find only 4 new transactions with a straightforward, and already reviewed code. This should make the review process faster. But of course, in the end we want these refactors.

Besides that, if you started end to end tests with 1a433d45, it is probably not good to change the source.

I will create a separate branch and implement these changes so we can merge them afterwards.

tarakby commented 3 years ago

@relatko sounds good, that works for me!