onflow / nft-catalog

https://www.flow-nft-catalog.com/
The Unlicense
35 stars 11 forks source link

Update transactions to avoid DUC leakage #104

Open austinsamsel opened 1 year ago

austinsamsel commented 1 year ago

@satyamakgec has done some excellent work to avoid DUC leakage in the "StorefrontListItem" and "StorefrontBuyItem" transactions:

https://github.com/onflow/TransactionMix/tree/main/transactions/nft-storefront-v2

Can we update the corresponding nft-catalog transactions to include these checks to avoid DUC leakage?

I'm not sure if there are wider implications or some additional context to consider.

I'd also be happy to open a PR to do this myself.

I think it'd be a good thing if we start considering the nft-catalog transaction templates as exemplar/standard.

i'm currently working on setting up some re-usable/multi-project workflow functionality around marketplace/storefront transactions and I'd like to depend more on nft-catalog.

I don't think I can start to rely on nft-catalog yet, until we can resolve this issue