onflow / nft-catalog

https://www.flow-nft-catalog.com/
The Unlicense
35 stars 11 forks source link

Fix Showing Errors and CSS On NFTs Page. #117

Closed prpatel05 closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nft-catalog ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 6:55PM (UTC)
aishairzay commented 1 year ago

Can we make the error go away when not typing? Also can the error be in the middle of the screen rather than on the left area.

prpatel05 commented 1 year ago

Fixed the error for typing

We would have to bring the "fetch" logic up one level in order and pass it to the component on the right. Additionally, the right component has its own error logic and messaging for failure to fetch/render NFTs.

I think we can make a seperate work item to fix/centralize error messaging for all components as a Toast of something later.