search

onflow / nft-catalog

https://www.flow-nft-catalog.com/
The Unlicense
35 stars 11 forks source link

add `nftType` field to EntryRemoved event #132

Closed austinkline closed 1 year ago

austinkline commented 1 year ago

Adds a field to the EntryRemoved event so that indexers can easily pick up what contract was impacted by the removal. Without this, indexers have to keep a mapping of collectionIdentifier -> type on their own so that when a removal event comes through, they know what type it belongs to

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nft-catalog ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 7:54PM (UTC)
aishairzay commented 1 year ago

Looks good - Tests failed here in github actions, but worked when i pulled it locally. Going ahead and merging it with that in mind.