search

onflow / nft-catalog

https://www.flow-nft-catalog.com/
The Unlicense
36 stars 13 forks source link

Can use the proposal Id `0` and update the totalProposals after assigning the catalog proposals #14

Closed satyamakgec closed 2 years ago

satyamakgec commented 2 years ago

Here https://github.com/dapperlabs/nft-catalog/blob/8cb26110e41190316e718bb0797da338f0713662/cadence/contracts/NFTCatalog.cdc#L194

We are not storing anything for proposal id 0

aishairzay commented 2 years ago

Any reason we should start at 0 instead of 1?

IMO it looks nicer and is more readable to start from 1. Also, it might be too late to make this change now that there have been some proposals made in mainnet