onflow / nft-catalog

https://www.flow-nft-catalog.com/
The Unlicense
36 stars 13 forks source link

"Visit Website" hyperlink is reading wrong externalsite url from contract #54

Closed mrkart closed 1 year ago

mrkart commented 1 year ago

https://www.flow-nft-catalog.com/catalog/mainnet/DisruptArt

"Visit Website" hyperlink was supposed to be taken from line 147 externalURL

//
 return MetadataViews.NFTCollectionDisplay(
                        name: "DisruptArt Collection",
                        description: "Discover amazing NFT collections from various disruptor creators. Disrupt.art Marketplace's featured and spotlight NFTs",
                        externalURL: MetadataViews.ExternalURL("https://disrupt.art"),
                        squareImage: media,
                        bannerImage: media,
                        socials: {
                            "twitter": MetadataViews.ExternalURL("https://twitter.com/DisruptArt"),
                            "instagram": MetadataViews.ExternalURL("https://www.instagram.com/disrupt.art/"),
                            "discord" : MetadataViews.ExternalURL("https://discord.io/disruptart")
                        }
                    )
                    //
                But it is taking wrongly from sample wallet address's token's externalURL from line 126. 
bshahid331 commented 1 year ago

Can you elaborate? The URLs seem the same on the contract:

https://flow-view-source.com/mainnet/account/0xcd946ef9b13804c6/contract/DisruptArt

mrkart commented 1 year ago

Hello Bilal.,

Please see our catalog submission https://www.flow-nft-catalog.com/catalog/mainnet/DisruptArt

And look at its “Vist Website” link below logo.

It is hyperlinked to some sample NFT’s IPFS url.

It is supposed to be hyperlinked to https://disrupt.art as per our above contract line 150

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: @.> Sent: 19 August 2022 19:08 To: @.> Cc: @.>; @.> Subject: Re: [dapperlabs/nft-catalog] "Visit Website" hyperlink is reading wrong externalsite url from contract (Issue #54)

Can you elaborate? The URLs seem the same on the contract:

https://flow-view-source.com/mainnet/account/0xcd946ef9b13804c6/contract/DisruptArt

— Reply to this email directly, view it on GitHubhttps://github.com/dapperlabs/nft-catalog/issues/54#issuecomment-1220694466, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIAMGJUTWEET3VQTXBBCZADVZ6E4HANCNFSM57ABLBCA. You are receiving this because you authored the thread.Message ID: @.***>

bshahid331 commented 1 year ago

Can you try submitting an update to the catalog? You can update the entry

mrkart commented 1 year ago

I logged in with the wallet, I see "DELETE PROPOSAL" as the only action available. Where can i find "Update" ?

bshahid331 commented 1 year ago

You can just submit a new collection with the same collection identifier and it will be treated as an update