onflow / nft-storefront

A general-purpose Cadence contract for trading NFTs on Flow

The Unlicense

102 stars 53 forks source link

Finalize and test V2 NFT Storefront code #37

Closed joshuahannan closed 2 years ago

joshuahannan commented 2 years ago

Context

We have a new proposal for a second version of NFT storefront. We need to finish it and make sure it is thoroughly tested

Definition of Done

Thoroughly review and discuss https://github.com/onflow/temp_nft-storefrontV2, looking for bugs and potential improvements.
Make a PR in the main nft-storefront repo with the finalized contract.
Write tests in https://github.com/onflow/nft-storefront/tree/main/lib/go/test

joshuahannan commented 2 years ago

@albeethekid @satyamakgec Have y'all found a time to discuss this and finalize the proposal yet? It would be great if Satyam could start working on testing it.