Stable Cadence Feature Branch

[joshuahannan]

Updates the storefront contracts to be compatible with stable Cadence.

• Changes some methods to be view, so they can be used in pre-conditions and post-conditions
• Uses the correct casting keyword as
• Added a Go deployment test for v2 nft storefront
• Updates go dependencies

[bluesign]

I think as Stable Cadence coming, maybe we can move pre/post conditions to interfaces as they should be.

[joshuahannan]

I think I disagree that pre/post conditions should only be in interfaces. I think that they should be in interfaces if possible, but there are a lot of times when you only want the conditions enforced on the concrete type, or when the things you want to be able to access in the condition are not even accessible in the interface anyway.

[bluesign]

I think that they should be in interfaces if possible, but there are a lot of times when you only want the conditions enforced on the concrete type...

@joshuahannan I am torn on this to be honest, one side of me sees NFTStoreFront as a standard ( that requires interfaces ) another assumes it is too critical to be interface instead of concrete.

when the things you want to be able to access in the condition are not even accessible in the interface anyway.

I think this is totally possible by adjusting interface

[turbolent]

Opened onflow/cadence#2125 to make more functions view

[turbolent]

Updated dependencies and reverted the change of the pre-conditions to asserts. Tests pass now