search

onflow / nft-storefront

A general-purpose Cadence contract for trading NFTs on Flow
The Unlicense
102 stars 53 forks source link

[FEATURE] Improve the NFT related functions #86

Open LanfordCai opened 1 year ago

LanfordCai commented 1 year ago
  1. Currently, we have a borrowNFT() function for Listing. It would be great if we could also have a borrowNFTSafe() function.
  2. Please add a borrowViewResolver() function to Listing. This will allow us to fetch the metadata of the NFT in a more straightforward way.
  3. Could you provide a function like getProviderAddress()? This would allow users to get the provider's address and know the source of the assets.
rheaplex commented 1 year ago

Regarding 3), this is tricky because the provider could lie. The less convenient route is the safer one here.