search

onfoot / homebridge-valetudo-xiaomi-vacuum

A Homebridge plugin for Xiaomi/Roborock vacuum cleaners running Valetudo
MIT License
31 stars 9 forks source link

Does this support selecting rooms? #20

Open miguelpruivo opened 3 years ago

miguelpruivo commented 3 years ago

I’m planning to root my S50, however, I’m used to use the rooms switches in the HK which really comes in handy (I just have to ask Siri to clean room X which is much faster than going to the MiApp). However, I don’t see in the docs here any reference to room support, do you have any plans? Thank you.

onfoot commented 2 years ago

Hey! I do have a plan to add rooms/zones as additional switches, but simply don't have time to do it currently. As soon as I figure out the Valetudo RE incompatibility, I'll most likely get on it, since it's something I'd like too.

miguelpruivo commented 2 years ago

Is it easy to add? I can issue a PR but never created a homebridge plugin myself despite being a developer as well. Where can I find the Valetudo API? Does it work with Valetudo or does it have an issue as well?

miguelpruivo commented 2 years ago

@onfoot I'd like to help you out on this one, could you give me some directions?

miguelpruivo commented 2 years ago

@onfoot is this project abandoned? 😔

onfoot commented 2 years ago

Sorry I keep giving this impression over and over again, but it's not abandoned at all! I just haven't had much time for this recently. But as I mentioned in the other issue, I have RE with actually working root access on my device now, so I'll be able to test out some stuff.

As for room selection, I've been thinking about it a bit and I think this plugin would have to be converted to a platform, so it can dynamically add and remove rooms, once they're updated on the device. Then it's just a matter of asking the vacuum API about the rooms available. I don't know if one can find out whether the vacuum is working in a chosen room currently, I'd have to check this.

However, official Valetudo's API is documented pretty nicely, but for RE you'd have to dig through the web client code which contains a client library.

miguelpruivo commented 2 years ago

Hi! No problem. Right now I’ve been able to have it all working through mqttthing. It’s a bit of trial & error but gets the job done.

nevertheless, even without the rooms feature this plugin wasn’t working for me as it is for the latest Valetudo version.

AlexKLMan commented 2 years ago

Love this plugin, thank you so much, I too would love a room selection, so I can put a clean button in each room within the Home app :)

AlexKLMan commented 1 year ago

Hi both, do we have any updates regarding the room cleaning? Thank you!