search

onfoot / homebridge-valetudo-xiaomi-vacuum

A Homebridge plugin for Xiaomi/Roborock vacuum cleaners running Valetudo
MIT License
31 stars 9 forks source link

Make commands configurable #21

Closed greatestview closed 1 year ago

greatestview commented 2 years ago

Hi, first of all: Thank you for your amazing work! I’m another niche user of a Xiaomi Robot with Valetudo in Homebridge. :D

One thing I noticed: The commands for cleaning, going home etc. are hard coded. I use voice commands a lot, so I thought it would be nice to make the voice commands configurable, as an option of course. homebridge-xiaomi-roborock-vacuum for example allows device name followed by a custom word, but that order might not make sense with all languages. So what about making the whole command name configurable?

@onfoot, I will attach a pull request and would be happy, if you could merge and publish it!

greatestview commented 2 years ago

Thanks for merging! Exited to see a new release on NPM :)