search

ongaeshi / replace-translator

Firefox addon translate and replace html page.
https://addons.mozilla.org/en-US/firefox/addon/replace-translator/
2 stars 0 forks source link

please update sdk so i can use this in alternate-named/branded builds and give if 5 stars! #1

Open DavidRosen opened 11 years ago

DavidRosen commented 11 years ago

The sdk version you're using is old and has a bug (in cuddlefish.js) that apparently makes the extension refuse to run in alternate-named Firefox builds such as Pale Moon or Iceweasel. This has been fixed in recent versions so I guess you just need to use the newer sdk version corresponding to firefox 21 or higher. See https://bugzilla.mozilla.org/show_bug.cgi?id=855651 and github.com/mozilla/addon-sdk/commit/50670c29c118fc69dd24269d51754f400b3306d4

I love Replace Translator and I can't understand why it hasn't gotten more attention -- it blows away all other translate-selected-text add-ons. I would like to give it 5 stars and spread the good word, if only I could run it in my browser (I use the latest Pale Moon: 20.3).

I already gave Transmaker a 5-star review but now I'm running into its bugs.

-dabruro ( addons.mozilla.org/firefox/user/dabruro/ )

ongaeshi commented 11 years ago

Hi, thank you for report.

Rebuild latest Add-on SDK. (Use replace-translater.xpi) https://github.com/ongaeshi/replace-translator/releases/tag/v1.0.2

Does it work in your Pale Moon ?

DavidRosen commented 11 years ago

Thanks for your quick response. When I try to install this, it says it isn't compatible with Pale Moon 20.3. With compatibility checking disabled I was able to install it but it still didn't work -- there was nothing in the context menu and the hotkey didn't work either. I checked cuddlefish.js in the xpi and it does indeed have the patch, so I don't know why it doesn't work. I didn't see anything in the error console. I even tried it with a fresh profile with no other add-ons.

On Sat, Aug 24, 2013 at 2:50 AM, ongaeshi notifications@github.com wrote:

Hi, thank you for report.

Rebuild latest Add-on SDK. (replace-translater.xpi) https://github.com/ongaeshi/replace-translator/releases/tag/v1.0.2

Does it work in your Pale Moon ?

— Reply to this email directly or view it on GitHubhttps://github.com/ongaeshi/replace-translator/issues/1#issuecomment-23204179 .

ongaeshi commented 11 years ago

I think sad that did not compatible.

If you get new Pale Moon compatibility information please tell. I also look for.

Thank you for the detailed report.