ongair / whatsapp

WhatsApp agent for Ongair
GNU General Public License v3.0
0 stars 1 forks source link

No error handling for logging permissions error #33

Open kimenye opened 8 years ago

kimenye commented 8 years ago

Sometimes the log file cannot be written to due to permissions. This causes an error when the application attempts to log something.

kimenye commented 8 years ago
Traceback (most recent call last):
  File "/home/deploy/apps/whatsapp/venv/bin/ongair-cli", line 18, in <module>
    main(sys.argv[1:])
  File "/home/deploy/apps/whatsapp/venv/bin/ongair-cli", line 13, in main
    client = Client(args['account'])
  File "/home/deploy/apps/whatsapp/venv/local/lib/python2.7/site-packages/ongair/client.py", line 28, in __init__
    setup_logging(phone_number)
  File "/home/deploy/apps/whatsapp/venv/local/lib/python2.7/site-packages/ongair/util.py", line 55, in setup_logging
    filemode='a')
  File "/usr/lib/python2.7/logging/__init__.py", line 1532, in basicConfig
    hdlr = FileHandler(filename, mode)
  File "/usr/lib/python2.7/logging/__init__.py", line 903, in __init__
    StreamHandler.__init__(self, self._open())
  File "/usr/lib/python2.7/logging/__init__.py", line 928, in _open
    stream = open(self.baseFilename, self.mode)
IOError: [Errno 13] Permission denied: '/home/deploy/apps/whatsapp/logs/555197557717.production.log'
kimenye commented 8 years ago

:point_up: Example of the stack trace.

kimenye commented 8 years ago

We use rollbar to monitor errors for the rest of our stack. They have a python package