[Story]: Add checkboxes to the items in the search filters

aleeexgreeen commented 4 weeks ago

What this PR accomplishes

Separates access level from filter sidebar and adds it to the search bar
Defaults to open upon opening the dataset search page or an individual group / ministry page
Defaults to open when all checkboxes are unchecked
Reduce templates rendered on the dataset page (improving marginally the performance of page)
Use of "search term" instead of "keyword(s)" and the use of "total"
Clear filters button and filter facets now submit form instead of redirecting to links with filters as params in URL
Search reset "x" now works when typing in a empty search box
Adds text to empty search with additional datasets are present in different access levels
Removes duplicate forms wrapping the search_form.html
Adds callout with search term (if present) and access level(s) selected
Adds an escape to the query string for search results

Issue(s) addressed

DATA-1083, DATA-1272, DATA-1514

What needs review

All filters should allow multiple checkboxes to be selected and operate as OR.
Relationship between filters should operate as AND
Callout is updated with every checkbox selected. When all checkboxes are selected "All levels" is displayed
Callout is updated when there is no results. Callout is updated when there is a search term present
The Access level filter should contain 3 items: Open, Under review and restricted. In this order Filters sidebar:
All selected checkboxes should be visible, including when there are more than 5 items (will not be bumping it to the top of list)
If there are more than 5 items selected than the default view be extended to more than 5 to include all selected items. Access level Zero results:
if there are zero results in a search with all 3 checkboxes selected Display message “Please try another search or reach out to us if you think data is missing.“
if there are zero results in a search for the selected checkbox(es) and there are datasets available in unselected checkboxes, there should be a message with a link to the search results of the access level with datasets displayed in the body of the page Other things needing review:
Translations are present and correct
implementation matches Figma design (to the best of my ability, Figma screens are not consistent)
The number of datasets on homepage equals total dataset amount and not open dataset amount
The number of datasets per on each Ministry on the ministry page is the total dataset amount and not open dataset amount
Navigating the website, there are no internal server errors
Clicking the search reset "x" when typing in a empty search box, resets the search box to empty

Tests should be done on individual ministry and group pages and the dataset search page

KatiRG commented 4 weeks ago

[x] All filters should allow multiple checkboxes to be selected and operate as OR.
[x] Relationship between filters should operate as AND
[x] Callout is updated with every checkbox selected. When all checkboxes are selected "All levels" is displayed
[x] Callout is updated when there is no results. Callout is updated when there is a search term present
[x] The Access level filter should contain 3 items: Open, Under review and restricted. In this order

Filters sidebar:

[x] All selected checkboxes should be visible, including when there are more than 5 items (will not be bumping it to the top of list)
[x] If there are more than 5 items selected than the default view be extended to more than 5 to include all selected items.

Access level Zero results:

[x] if there are zero results in a search with all 3 checkboxes selected Display message “Please try another search or reach out to us if you think data is missing.“
[x] if there are zero results in a search for the selected checkbox(es) and there are datasets available in unselected checkboxes, there should be a message with a link to the search results of the access level with datasets displayed in the body of the page

Other things needing review:

[x] Translations are present and correct
[x] implementation matches Figma design (to the best of my ability, Figma screens are not consistent)
[x] The number of datasets on homepage equals total dataset amount and not open dataset amount
[x] The number of datasets per on each Ministry on the ministry page is the total dataset amount and not open dataset amount
[x] Navigating the website, there are no internal server errors
[x] Clicking the search reset "x" when typing in a empty search box, resets the search box to empty

Pages to test:

[x] Tests should be done on individual ministry and group pages and the dataset search page

KatiRG commented 4 weeks ago

issue clearing filters: if I select e.g. XLSX, it will display as checked and the filter pill will also display under the search bar. If I select XLSX again to clear it, it does not clear, and a second filter pill will be added: Screenshot 2024-08-20 at 14 22 22

KatiRG commented 4 weeks ago

The count in the filter pill sometimes show 0 instead of the count shown in the facet:

Screenshot 2024-08-20 at 14 30 43

aleeexgreeen commented 4 weeks ago

The count in the filter pill sometimes show 0 instead of the count shown in the facet:

How can I reproduce this issue?

KatiRG commented 4 weeks ago

The count in the filter pill sometimes show 0 instead of the count shown in the facet:

How can I reproduce this issue?

This is reproducible on data4. Another example (on data4): choose ministry "Energy". The facet says "Energy (12)" but the pill shows "Energy (0)".

KatiRG commented 3 weeks ago

Some strange behaviour with pill counts again. Steps to reproduce (on data4):

go to datasets page and click DIOXIN (2) topic. Two open datasets will be displayed, as expected.
select Forestry (3) topic. Total 5 open datasets will be displayed, as expected.
now click Restricted (1) checkbox. Total 6 datasets will be displayed, as expected, however:
- DIOXIN (0) pill shown with 0 counts
- DIOXIN is no longer in the Topics facet list

Screenshot 2024-08-22 at 13 20 44

A similar test:

go to datasets page and click DIOXIN (2) topic. Two open datasets will be displayed, as expected.
click checkbox Restricted (0). Same two datasets are listed, as expected, however DIOXIN (0) pill shows 0 count.

aleeexgreeen commented 3 weeks ago

Some strange behaviour with pill counts again. Steps to reproduce (on data4):

go to datasets page and click DIOXIN (2) topic. Two open datasets will be displayed, as expected.

select Forestry (3) topic. Total 5 open datasets will be displayed, as expected.

now click Restricted (1) checkbox. Total 6 datasets will be displayed, as expected, however:

DIOXIN (0) pill shown with 0 counts

DIOXIN is no longer in the Topics facet list

A similar test:

go to datasets page and click DIOXIN (2) topic. Two open datasets will be displayed, as expected.

click checkbox Restricted (0). Same two datasets are listed, as expected, however DIOXIN (0) pill shows 0 count.

@KatiRG I was able to reproduce the issues described, but the issue is because of how the topics works. The topics return the 50 topics in descending order of dataset count. The last topic in displayed in the first test has a dataset count of 3, which is higher than 2 and that's why DIOXIN is not in the topic count. The issue is that topics are no longer reducing based on selected topics, as it does on prod. Maya suggested previously, not using the checkboxes on the topics until the topics/keywords are figured out, we may have to take this approach.

KatiRG commented 3 weeks ago

Re low-count topics: As discussed with team, this case will resolve when the keywords are cleaned up, so we will let this pass for now.

KatiRG commented 1 week ago

Can you djlint the html files?

KatiRG commented 4 days ago

@aleeexgreeen I found the following case where 1 dataset exists at level Restricted but when the Restricted access level is selected with the Open checkbox selected as well (also when all checkboxes are selected), that dataset is not shown and the callout says "No datasets": Screenshot 2024-09-13 at 15 23 16

Steps to reproduce:

select Restricted then deselect Open
select Topic aggregates (1)
select Open checkbox (and can also select Under Review checkbox so that all checkboxes are selected)

aleeexgreeen commented 4 days ago

@aleeexgreeen I found the following case where 1 dataset exists at level Restricted but when the Restricted access level is selected with the Open checkbox selected as well (also when all checkboxes are selected), that dataset is not shown and the callout says "No datasets":

Steps to reproduce:

select Restricted then deselect Open

select Topic aggregates (1)

select Open checkbox (and can also select Under Review checkbox so that all checkboxes are selected)

Hi @KatiRG, I don't have the environment or access set up at the moment, but can you revert the change proposed in https://github.com/ongov/ckanext-ontario_theme/pull/598#discussion_r1750608059 and let me know if this is still an issue?

KatiRG commented 1 day ago

@aleeexgreeen I found the following case where 1 dataset exists at level Restricted but when the Restricted access level is selected with the Open checkbox selected as well (also when all checkboxes are selected), that dataset is not shown and the callout says "No datasets": Steps to reproduce:

select Restricted then deselect Open

select Topic aggregates (1)

select Open checkbox (and can also select Under Review checkbox so that all checkboxes are selected)

Hi @KatiRG, I don't have the environment or access set up at the moment, but can you revert the change proposed in #598 (comment) and let me know if this is still an issue?

Thanks @aleeexgreeen ! This solves the problem. I didn't notice the brackets around the second or grouping! I'll revert

ongov / ckanext-ontario_theme