search

ongr-io / ElasticsearchBundle

Symfony bundle for Elasticsearch with steroids
MIT License
313 stars 189 forks source link

Restrict compatible PHP versions to currently supported ones #858

Closed YetiCGN closed 5 years ago

YetiCGN commented 5 years ago

We haven't tested PHP 7.3, 7.4, 8.0 or 9.0 yet, so we shouldn't claim compatibility with every version greater than or equal to PHP 5.6.

saimaz commented 5 years ago

Agree. In that case we will avoid the future conflicts. Thanks for the notice.

YetiCGN commented 5 years ago

Thanks!

What about a merge to master? Is that a good idea? If so, should I open another PR or will you change it?

saimaz commented 5 years ago

I will merge it to the master later. If you want to introduce any new change as a PR you should start from the branch as in the version you are targeting to release.

HcErwin commented 4 years ago

I'm running v5.2.* for a while now on 7.4 locally and works great. Due to the restriction I can't update my test/staging server through my pipelines (can't hack like locally). Maybe we can unlock 7.4?

YetiCGN commented 4 years ago

@HcErwin 6.0.* supports PHP 7.4, can you upgrade to the next major version?

HcErwin commented 4 years ago

Sadly no, because our platform is quite big and is still locked to Elastic 5.*. Otherwise I would've certainly upgraded, but still discussing the upgrade to 6 or 7 for now :)

YetiCGN commented 4 years ago

Then you could fork the repository and change the restriction in the ElasticsearchBundle composer.json, commit and push to your fork's branch and include that as a repository in your project's composer.json like this:

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/HcErwin/ElasticsearchBundle"
        }
    ],
HcErwin commented 4 years ago

That sounds the most logical for now indeed; thank you! :D

patie commented 2 years ago

can u please add support for PHP8? 🙏