ongr-io / ElasticsearchBundle

Symfony bundle for Elasticsearch with steroids
MIT License
313 stars 189 forks source link

Fix return type of AbstractResultsIterator::getDocumentScore() #938

Open jdreesen opened 4 years ago

jdreesen commented 4 years ago

It returns null when there is no score.

codecov-io commented 4 years ago

Codecov Report

Merging #938 into 6.2 will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                6.2     #938   +/-   ##
=========================================
  Coverage     66.61%   66.61%           
- Complexity      423      424    +1     
=========================================
  Files            39       39           
  Lines          1393     1393           
=========================================
  Hits            928      928           
  Misses          465      465           
Impacted Files Coverage Δ Complexity Δ
Result/AbstractResultsIterator.php 86.90% <100.00%> (ø) 40.00 <4.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac771ff...8328343. Read the comment docs.