search

ongr-io / ElasticsearchBundle

Symfony bundle for Elasticsearch with steroids
MIT License
313 stars 189 forks source link

Instantiate document classes without calling their constructor when denormalizing #944

Open jdreesen opened 4 years ago

jdreesen commented 4 years ago

Denormalization restores a document class from its state, which means that the constructor should not be called because no new object is created there.

This also allows the document class's constructor to be parametrized because it doesn't get called in this library anymore.

codecov-commenter commented 4 years ago

Codecov Report

Merging #944 into 6.2 will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                6.2     #944      +/-   ##
============================================
+ Coverage     66.61%   66.66%   +0.04%     
- Complexity      423      424       +1     
============================================
  Files            39       39              
  Lines          1393     1395       +2     
============================================
+ Hits            928      930       +2     
  Misses          465      465
Impacted Files Coverage Δ Complexity Δ
Mapping/Converter.php 94.11% <100.00%> (+0.24%) 21.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac771ff...196a7c2. Read the comment docs.