ParametersTrait::addParameter() to return self

ongr-io / ElasticsearchDSL

Query DSL library for Elasticsearch

MIT License

461 stars 200 forks source link

ParametersTrait::addParameter() to return self #303

Closed mab-on closed 4 years ago

mab-on commented 4 years ago

It would be nice if ONGR \ ElasticsearchDSL \ ParametersTrait :: addParameter would return self (same way it is implemented in ParametersTrait :: setParameters () already).

saimaz commented 4 years ago

I will add this, thanks for the hint @mab-on

ilvalerione commented 4 years ago

There's a pending pull request to integrate this behaviour. @saimaz if you need something different than I coded, comment my pull request, I'll apply the changes.

saimaz commented 4 years ago

It's already merged. Will be released soon ;)