ongr-io / ElasticsearchDSL

Query DSL library for Elasticsearch
MIT License
461 stars 200 forks source link

Allow zero indexed keys on RangeAggregation #316

Open Syntaf opened 4 years ago

Syntaf commented 4 years ago

Allow '0' as a valid key for RangeAggregation objects

Syntaf commented 4 years ago

@saimaz 👋 do you have a moment to take a look at this bugfix? Thanks!

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.67%. Comparing base (b4c3c89) to head (4bc0fa1).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #316 +/- ## ========================================= Coverage 78.67% 78.67% Complexity 736 736 ========================================= Files 123 123 Lines 1899 1899 ========================================= Hits 1494 1494 Misses 405 405 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.