Incomplete ESB 1.0 integration - Githubissues

ongr-io / TranslationsBundle

Translations GUI for translating Symfony static strings

MIT License

5 stars 13 forks source link

Incomplete ESB 1.0 integration #66

Closed mvar closed 8 years ago

mvar commented 8 years ago

Few places stopped working after ESB 1.0 integration. Because of lack of tests these were not spotted until now.

Best way to catch all of them would be to setup demo project and test all actions available in UI. Commands looks to be working well.

Few spotted places:

History document has public properties, but various services calls getters and setters. Public properties should be replaced by getters and setters.
TranslationManager tries to get document from document iterator by key. This wont be supported by ESB 1.0

Relates #60