search

ongr-io / TranslationsBundle

Translations GUI for translating Symfony static strings
MIT License
5 stars 13 forks source link

Xliff exporter #88

Open virgixas opened 8 years ago

virgixas commented 8 years ago

Xliff exporter, exporter interface changes, configuration changes, bugfix Storage/ElasticsearchStorage.php - ES namespace, bugfix DependencyInjection/ONGRTranslationsExtension.php - missing event listener, README chages

saimaz commented 8 years ago

Thanks for PR @virgixas. There is one little place I would like you to fix which I commented in your code.

virgixas commented 8 years ago

Hey, yes a think the same, but i couldn't find any way how configure exporter: and use this as service name in bundle config. Could somebody help with this ?

On 28 July 2016 at 12:05, Simonas Šerlinskas notifications@github.com wrote:

Thanks for PR @virgixas https://github.com/virgixas. There is one little place I would like you to fix which I commented in your code.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ongr-io/TranslationsBundle/pull/88#issuecomment-235840425, or mute the thread https://github.com/notifications/unsubscribe-auth/ADUbkWGgUSUSyKyFWotxHLcvL3bAOiLUks5qaHDDgaJpZM4JW88A .

saimaz commented 8 years ago

IMO The most easiest solution would be to not add configuration. Just define services. If for some reason provided exporter is not enough, you can overwrite service definition in your project and use your custom exporter service.

Otherwise you need to create compiler pass, create service definition and pass all dependencies as references.

saimaz commented 8 years ago

Ok, let me help you to make a todo: