search

ongr-io / demo.ongr.io

Demo application of ONGR.
http://ongr.io
MIT License
29 stars 24 forks source link

[BUG] Import-command didn't throw any error message when it failed. #154

Closed trandangtri closed 8 years ago

trandangtri commented 8 years ago

Now, the import command runs in silent. It won't throw any error message/exception when it failed. This problem occurred in all import-commands, including product, category and content.

Version: dev-master

asev commented 8 years ago

Hello. Are you talking about invalid data problems (string instead of integer and etc)? In this case, yes you are right. Commit method does not check the output in 0.10 and neither in alpha releases. So you won't see any warning not only at import, but for all bulk operations. But I don't think it's a bug. It's more like a feature request for ongr-io/ElasticsearchBundle. To have a way to track bulk operation errors.

murnieza commented 8 years ago

Yes. That's definitely a problem in ESB. Errors from bulk should be at least logged. Feel free to close this issue and reopen it in correct bundle.

trandangtri commented 8 years ago

Yeah, maybe you're right. This issue should be in https://github.com/ongr-io/ElasticsearchBundle. I will close this issue here. Please continue to follow this at https://github.com/ongr-io/ElasticsearchBundle/issues/482

Thanks all guys.