ongres / scram

SCRAM (RFC 5802) Java implementation
BSD 2-Clause "Simplified" License
26 stars 11 forks source link

Consider using the JDK java.util.Base64 instead of shaded bouncycastle version #17

Closed lukaseder closed 6 months ago

lukaseder commented 2 years ago

JDK 8 now has a java.util.Base64 class for encoding and decoding, meaning that once you upgrade your baseline from Java 7 to Java 8, you can remove com.ongres.scram.common.bouncycastle.base64.Base64 and the other classes in that package. The removal can then be picked up by pgjdbc, which shades this class once again as org.postgresql.shaded.com.ongres.scram.common.bouncycastle.base64.Base64, etc.

Benefits:

jorsol commented 2 years ago

Java 7 was the baseline for SCRAM, but now that PgJDBC moved to Java 8 we can follow.

So the plan is to also use Java 8 as baseline too. Thanks for bring this up.