ongteckwu / typeid-ts

TypeID UUIDv7 implementation in Typescript (Lib and CLI)
Apache License 2.0
38 stars 5 forks source link

0.3.0 release does not have new import method #8

Open DanHulton opened 1 year ago

DanHulton commented 1 year ago

I think the 0.3.0 version on npm did not have build run successfully on it before being published - it's missing the new await-free import method from https://github.com/ongteckwu/typeid-ts/pull/7.

If you update a project's dependency to 0.3.0 of this library and install it, then cat node_modules/typeid-ts/build/cjs/src/lib/basics.js, the old const uuidv7_1 = require("uuidv7"); require method is still there.

marco-verbeek commented 1 year ago

👋🏼 hello! Indeed, this seems to not have been published correctly.

@ongteckwu would it be possible to publish a new version with a fresh build ? 🙏🏼

Thank you!

ongteckwu-assurity commented 1 year ago

@marco-verbeek sure I will do that

ongteckwu commented 1 year ago

published, leet me know if it works marco

marco-verbeek commented 1 year ago

@ongteckwu It seems like I'm still getting the same error on version 0.3.1.

/node_modules/typeid-ts/build/cjs/src/lib/basics.js:5
const uuidv7_1 = require("uuidv7");
                 ^
Error [ERR_REQUIRE_ESM]: require() of ES Module /home/marco/Repositories/easy-auth/node_modules/uuidv7/dist/index.js from /node_modules/typeid-ts/build/cjs/src/lib/basics.js not supported.
Instead change the require of index.js in /node_modules/typeid-ts/build/cjs/src/lib/basics.js to a dynamic import() which is available in all CommonJS modules.

Could you double check if the require is still there on your end as well ? 🙏🏼 Let me know if there's anything I can help with.

I highly appreciate your time, thank you so much!

ongteckwu commented 1 year ago

ok can you try again. Sorry was busy whole week.

kodditor commented 5 months ago

Still seeing the error in v0.3.8 @ongteckwu