ongweijie7 / pe

0 stars 0 forks source link

Able to input multiple name prefixes #5

Open ongweijie7 opened 1 year ago

ongweijie7 commented 1 year ago

Screenshot 2023-04-14 at 2.31.59 PM.png When the above command is given above, I would expect the command to fail and cough out an error since there are multiple prefixes given, however, the command goes through and only the second name is added as shown in the picture below.

Screenshot 2023-04-14 at 2.33.31 PM.png

This might inconvenient the user when he/she accidentally puts in another 'n/' prefix.

nus-pe-script commented 1 year ago

Team's Response

duplicate

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Can take 2 time prefixes

When given a command like this "add_alarm t/10000000000000000000000000000000 t/1000 c/hellosdasdadadadadadadadaaaadaa". The application allows the adding of the second time.


[original: nus-cs2103-AY2223S2/pe-interim#2968] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

This behaviour is intended, as explained in the user guide.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Screenshot 2023-04-18 at 2.19.45 PM.png

I believe the bugs can only be fixed independently since they concern different prefixes and different commands.


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I believe this is of medium severity since an accident can result in the TA accidentally stringing two add students command without realising and losing information as there are no errors thrown.