Refactor + fix bugs in repeated field code generation

oniksan / godobuf

A Google Protobuf implementation for Godot / GDScript

BSD 3-Clause "New" or "Revised" License

261 stars 36 forks source link

Closed conradhappeliv closed 2 years ago

conradhappeliv commented 2 years ago

This should only have two major changes in generated code:

fixes #21: the "clear" method for repeated fields now sets it to an array instead of the field's type, e.g. int32
fixes #22: now has a setter for repeated fields

Diffs of generated repeated scalar code:

And an example of a generated repeated message code (ModeState is a message defined elsewhere):

oniksan commented 2 years ago

It breaks backwards compatibility, so I won't merge it.

If you want, you can write code that supports both (old and new) methods of setting repeated fields: In addition to this, you need: