search

oniksan / godobuf

A Google Protobuf implementation for Godot / GDScript
BSD 3-Clause "New" or "Revised" License
261 stars 36 forks source link

Support for typed GDScript #5

Closed jameswestman closed 4 years ago

jameswestman commented 4 years ago

GDScript now supports optional types. This feature helps with code readability and maintainability, and it also improves code completion in the editor. It would be great if Godobuf added types to its generated code (in function parameters and return values) to take advantage of this feature.

oniksan commented 4 years ago

Already thinking about it ... Not enough time yet ... I'll keep it on mind

jakobwinkler commented 4 years ago

Hey, I'm using godobuf in my current project and I too would like to have the type annotations generated. If you're okay with it @oniksan I'll implement it and send a pull request in the next couple of days.

oniksan commented 4 years ago

Are you already writing code? If not, then do not write, I will do it myself.

jakobwinkler commented 4 years ago

I had a look through the code yesterday and wanted to get started tonight. I'm fine with it either way. Let me know if I can help.

oniksan commented 4 years ago

I'll try to fix it myself today or tomorrow. If I don’t have time, I will write to you.

jakobwinkler commented 4 years ago

Great, thanks!

oniksan commented 4 years ago

Done: https://github.com/oniksan/godobuf/releases/tag/v0.4.0 If there will be bugs write to me.