search

onimitch / ffxi-balloon-ashitav4

This is an Ashita v4 port of the Balloon addon, forked from StarlitGhost's version. The original Windower Balloon addon was created by Hando and modified by Kenshi, Yuki and Ghosty.
Other
3 stars 1 forks source link

Text shifts slightly when wrapping to a new line #5

Closed Herschel closed 6 months ago

Herschel commented 7 months ago

When Balloon is displaying a long text string, there will be a sudden ~1 pixel shift when the text animation wraps to a new line, probably due to some inconsistency the gdifonttexture clip range logic when a newline occurs.

Example video: https://github.com/onimitch/ffxi-balloon-ashitav4/assets/36278/28677e30-e540-4b51-bdfc-93629d0d1377

Test case:

tests.wrap_jitter = {
    'Nebibi',
    "But we ladies-in-waiting mustaru go on being our usual perky-werky selves. I can't let my bed-making standards drop just because times are tough!",
    ''
}
onimitch commented 7 months ago

I've definitely seen this too. As to when this might get fixed is hard to say since it's a fairly low priority issue. But i'll keep it in mind when I next look at anything relating to the gdifont side.

onimitch commented 6 months ago

I think I've found a fix for this, will push my changes later if you want to test it too.

onimitch commented 6 months ago

Fixed in 4.2.0