search

onimitch / ffxi-balloon-ashitav4

This is an Ashita v4 port of the Balloon addon, forked from StarlitGhost's version. The original Windower Balloon addon was created by Hando and modified by Kenshi, Yuki and Ghosty.
Other
3 stars 1 forks source link

Balloon tests failing in HorizonXI #7

Closed Tavo5691 closed 7 months ago

Tavo5691 commented 7 months ago

Just installed version 4.0.4 and wanted to run the tests cases to check my config, running any test causes the addon to unload

balloon-error

I'm not sure if other addons could cause this but changing line 619 to this seems to fix the issue, at least for me:

local message_prefix = (npc_name ~= '' and npc_name .. ' : ') or ''

That ensures message_prefix is not boolean before concatenating in line 620.

onimitch commented 7 months ago

Thanks for this. It does indeed look like a syntax error, thanks for spotting it. I made a last minute change to tidy that code up and must have not tested it fully, apologies.

I’ll apply your fix in a release tomorrow.

onimitch commented 7 months ago

Fixed in 4.1.0