onimp / oni_multiplayer

Oxygen Not Included multiplayer mod. Work in progress.
MIT License
225 stars 17 forks source link

Fixed msbuild holding dll lock during AttributeProcessor task #267

Closed thormme closed 1 year ago

thormme commented 1 year ago

For some reason, on my machine, building the solution failed while running the AttributeProcessor MSBuild task. The issue being that msbuild.exe held a reference to the MultiplayerMod.Original.dll file after opening with ModuleDefMD.Load(). It would then fail to delete the file during cleanup. I've simply changed it to open a stream and close it after reading the file. I figured I couldn't be the only one this is affecting. Though in all probability it's something to do with my build environment. Figured I'd throw this up here in case you're interested.

VS2022 x64 Windows 10

Love the mod!