Fix Unity scheduler - Githubissues

onimp / oni_multiplayer

Oxygen Not Included multiplayer mod. Work in progress.

MIT License

218 stars 18 forks source link

Closed polycone closed 7 months ago

polycone commented 7 months ago

I've noticed we have several issues with the Unity task scheduler:

Duplicated tasks (double execution was prevented by the Task implementation anyway, but still)
Exceptions aren't forwarded to the calling method (can produce false positive outcomes)

These issues are addressed in this PR.

@zuev93 Please check ClientChoresMustBeCancelled(WorkChore`1[MedicinalPillWorkable],System.Func`1[System.Object[]])

zuev93 commented 7 months ago

To fix the test: Could you add chore.addToDailyReport = false; to the test method?

    Thanks!