onionshare / onionshare

Securely and anonymously share files, host websites, and chat with friends using the Tor network
https://onionshare.org/
Other
6.27k stars 646 forks source link

Possibility of sending only one file without converting it on a .zip file #663

Closed emmapeel2 closed 6 years ago

emmapeel2 commented 6 years ago

I would like to use OnionShare more, to send images or text files to users, but many times people don't feel comfortable clicking on a zip onion link for security reasons. I would like to be able to send them the file without compressing it on a zip file.

It will be a bigger transaction, but in some cases it is not a problem. Or could be optional.

micahflee commented 6 years ago

This isn't actually a duplicate. #653 was requesting the ability to download each file individually. This issue is, if you're only sharing one file, don't zip it. If you're sharing multiple files, zip them like normal.

I think this is a fine thing to implement, so long as we can make sure both OnionShare and Tor Browser can do http gzip compression on that file.

micahflee commented 6 years ago

Potentially relevant:

https://github.com/closeio/Flask-gzip https://github.com/libwilliam/flask-compress http://flask.pocoo.org/snippets/122/

Baccount commented 6 years ago

Thanks for the explanation @micahflee

emmapeel2 commented 6 years ago

Count me in for any testing!

mig5 commented 6 years ago

Fixed in https://github.com/micahflee/onionshare/pull/774 !

jvoisin commented 2 years ago

Unfortunately, I'd like to share a 5G file with some friends, which is already heavily compressed. I don't want to have OnionShare compressing it again in gzip, nor do I want to uncompress it since its content is huge.