search

oniony / TMSU

TMSU lets you tags your files and then access them through a nifty virtual filesystem from any other application.
Other
2.03k stars 118 forks source link

Mounthelper enhancements - fix setting the DB's path #245

Closed mpeter50 closed 2 years ago

mpeter50 commented 2 years ago

I've made some changes to the mount helper script to fix #239 , and also changed the documentation shows by tmsu help mount, so it shows the correct usage of the mount command.

Could you take a look please?

As you can see earlier I've modified the script so that it prints some information useful for debugging. I've put half of that behind a variable which disables it by default, but I've kept the --verbose option on the TMSU command, because I didn't find a way to make it conditional while keeping the script easy to follow. What do you think of that? Is it ok? Do you have a suggestion on how to change it? What I tried is moving the global options into a variable, that is modified at 2 places, and referencing that variable in the commands at the bottom, but I found it unnecessarily hard to follow.

oniony commented 2 years ago

Could you please rebase and I will merge. Thanks, Paul.