search

onitake / gslx680-acpi

ACPI/x86 compatible driver for Silead GSLx680 touchscreens
GNU General Public License v2.0
71 stars 33 forks source link

Using get_unaligned_le16 instead of packed structures #3

Closed barni2000 closed 4 years ago

barni2000 commented 8 years ago

I found a TODO in the code. I did it.

onitake commented 8 years ago

Wow, thank you. The TODO comment was more of a note to self, not something I actually planned to do. get_unaligned_* is definitely more portable, but less readable than packed structs.

I think get_unaligned_le16 does the byteswapping automatically, no need to le16_to_cpu afterwards. See here.

gsantner commented 6 years ago

is this still WIP or not needed anymore?

onitake commented 6 years ago

Sorry, this got bogged down. I'll review and merge it ASAP.

gsantner commented 6 years ago

(Y)

jabjoe commented 6 years ago

This looks ok, this all worked last time I checked. But I've not even looked at this code in a long time and you have so... I'll just merge. :-)

onitake commented 6 years ago

I've actually abandoned gslx680-acpi in the meantime, as there's a better driver in the Linux kernel now. It supports both ARM/DeviceTree and x86/ACPI. I guess there's not too much harm in merging this now. I'll look it over and merge it.