onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 301 forks source link

Quick Info stopped showing #1441

Open MikaAK opened 6 years ago

MikaAK commented 6 years ago

I just updated to the latest oni and I've noticed that the quick info stopped showing entirely. It used to stop after about 30 min but now it doesn't work even after restarting oni!

Oni Config

const activate = (oni) => {
  oni.input.unbind('<C-p>')
  oni.input.unbind('<Tab>')
  oni.input.unbind('<C-n>')
  oni.input.unbind('<C-tab>')
  oni.input.unbind('<m-e>')
  oni.input.unbind('<down>')
  oni.input.unbind('<up>')

  oni.input.bind('<esc>', 'language.rename.cancel')

  oni.input.bind(['<shift-tab>', '<up>'], 'contextMenu.previous')
  oni.input.bind(['<tab>', '<down>'], 'contextMenu.next')
  oni.input.bind(['<shift-tab>', '<up>'], 'menu.previous')
  oni.input.bind(['<tab>', '<down>'], 'menu.next')
  oni.input.bind('<m-w>', () => document.querySelector('.tab.selected .corner.enable-hover').click())
}

const deactivate = () => {
}

module.exports = {
   activate,
   deactivate,
  "editor.maximizeScreenOnStart": true,
  "oni.useDefaultConfig": false,
  "oni.loadInitVim": true,
  "ui.fontSmoothing": "subpixel-antialiased",
  "ui.colorscheme": "molokai",
  "editor.fontFamily": "Hack",
  "ui.fontFamily": "Hack"
}
TalAmuyal commented 6 years ago

Do you have any related errors on the DevTools?

MikaAK commented 6 years ago

It's possible, currently seeing a few errors in the console. screen shot 2018-02-05 at 3 56 37 am

screen shot 2018-02-05 at 3 34 33 am screen shot 2018-02-05 at 3 37 40 am

TalAmuyal commented 6 years ago

@MikaAK can you please provide reproduction steps?

For instance, does the following work as expected? :e a.ts<cr>aMath.floor(

MikaAK commented 6 years ago

Most of these errors occur on startup. The child prop errors are already listed in #1261 It works at the start but at some point during my typing and after about 900 of these prop errors it stops working.

This error seems to happen around autocomplete stopping to work which is usually around the same time screen shot 2018-02-07 at 2 59 15 am

TalAmuyal commented 6 years ago

Didn't try to get to the bottom of that yet, but might https://github.com/onivim/oni/pull/1457 be related? (you can try using the current master & see if it still happens).

I too had similar problem, though I'm not sure what the pattern is. It mostly works, but sometimes it doesn't...

MikaAK commented 6 years ago

Going to update to current master and try

akinsho commented 6 years ago

@MikaAK unfortunately this error is still present on master I've been looking into it and it seems to be that lsp throws an error not sure why which takes down completion. Discussed this in #1513 if you're interested in the discussion so far but still a [WIP]

EDIT: to clarify the error Im discussing is the last one you posted a pic of the Debug Failure etc. which I believe is the cause of losing lsp functionality as the lsp goes down so would make sense that autocomplete and quickinfo go down as well.

I wonder if you can also reproduce this error when say you have typescript project open if you open a new file e.g. :e test.ts does this throw the error, this is how it reproduces for me but I'm curious if that's a definite cause for the failure