onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.36k stars 300 forks source link

launching in background from shell causes runaway subshells #1890

Open jaawerth opened 6 years ago

jaawerth commented 6 years ago

Love the editor - it's great to see a project that's come this far in taking advantage of Neovim's remote capabilities! I generally go back and forth between this and regular Neovim in the shell, but I've noticed the following problem:

The issue

When launching in the background from the shell (to, say, open it in the current directory) without blocking the tty),

Further exploration

I've tried a few variations on this (including nohup and redirecting stderr/stdout) without any luck, as well as disabling the use of my init.vim and using stock oni configuration. The same thing does not seem to occur in plain neovim.

I've heard a couple people mention similar issues in other electron apps, so I thought it might be an electron issue, but I tried starting a base electron app in the background and that didn't seem to have any trouble... though it's possible an electron app that doesn't really do anything isn't going to reproduce the issue.

Environment

Thanks!

oni-bot[bot] commented 6 years ago

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

jaawerth commented 6 years ago

Screenshots:

Initial issue

screenshot from 2018-03-22 13-44-02 screenshot from 2018-03-22 13-43-46 screenshot from 2018-03-22 13-44-51

Getting it to run:

screenshot from 2018-03-22 13-45-47 screenshot from 2018-03-22 13-46-01