onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 299 forks source link

vim.init symlink not followed #2418

Open hakunin opened 6 years ago

hakunin commented 6 years ago

Oni Version: 0.3.6

Neovim Version (Linux only): Operating System: Mac OSX 10.12.5

Issue: When I installed neovim it suggested making a symlink to my ~/.vimrc file.

Expected behavior: Load up the ~/.vimrc file

Actual behavior: Doesn't load anything

Steps to reproduce: Have a symlink pointing to the config.

PS: How do I point Oni to a different file? I want to have a different config for it.

oni-bot[bot] commented 6 years ago

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

CrossR commented 6 years ago

Just to check, do you have "oni.loadInitVim": true, set in your Oni config? Otherwise the config won't be loaded at all. To my knowledge, symlinks should work, I use a symlink for my configs on both Windows and Arch, though haven't tested it on Mac.

If you want to use a different init.vim you'd instead just use "oni.loadInitVim": "/home/ryan/path/to/init.vim, or alternatively you can use the following to add/remove Oni features from Oni specifically:

if exists('g:gui_oni')
    " Statements here
endif

There is some more on that over in https://github.com/onivim/oni/wiki/How-To:-Minimal-Oni-Configuration, as well as some recommendations about turning of the default config if you are using your own (to minimise conflicts), as well as what the default config is so you can bring over any relevant settings.

hakunin commented 6 years ago

Thanks, I am new to this and thought I clicked the option to enable it but I guess I didn't.

"oni.loadInitVim": true,, exit, open, nothing changed. (If I manually do so % on the file I get immediately my color scheme and soft tabs)

"oni.loadInitVim": "/Users/michal/.vimrc", exit, open, nothing

Here is the whole file, I think I just changed that one line:

import * as React from "react"
import * as Oni from "oni-api"

export const activate = (oni: Oni.Plugin.Api) => {
    console.log("config activated")

    // Input
    //
    // Add input bindings here:
    //
    oni.input.bind("<c-enter>", () => console.log("Control+Enter was pressed"))

    //
    // Or remove the default bindings here by uncommenting the below line:
    //
    // oni.input.unbind("<c-p>")

}

export const deactivate = (oni: Oni.Plugin.Api) => {
    console.log("config deactivated")
}

export const configuration = {
    //add custom config here, such as

    "ui.colorscheme": "nord",

    //"oni.useDefaultConfig": true,
    //"oni.bookmarks": ["~/Documents"],
    //"oni.loadInitVim": true,
    "oni.loadInitVim": "/Users/michal/.vimrc",
    //"editor.fontSize": "12px",
    //"editor.fontFamily": "Monaco",

    // UI customizations
    "ui.animations.enabled": true,
    "ui.fontSmoothing": "auto",
};
CrossR commented 6 years ago

Just to check, since you are on mac, when you say "exit" do you mean fully-closing Oni? That is, closing the Window and then quitting completely from the dock? We haven't updated Oni (yet) to reload the config on the fly, rather it calls neovim with a commandline flag, so Oni must be fully restarted.

Otherwise...thats odd. I'll see if I can test this on Mac over the weekend, since it should work there like anywhere else.

hakunin commented 6 years ago

I use the exit option to be sure. (last item in menu) screen shot 2018-07-11 at 14 09 03

I am sure I am doing something wrong so if anyone wants to skype quickly and try a few things just let me know.