Windows 64 bit installer is actually 32 bit

[digital-carver]

Operating System: Windows 7 64 bit

Issue: The "Oni installer (x64) for Windows" from the Installation Guide tries to install to "Program Files (x86)", and seems to be a 32-bit installer.

> sigcheck64.exe D:\Setups\Oni-0.3.6-win.exe

d:\setups\Oni-0.3.6-win.exe:
        [...]
        Description:    Oni Setup
        Product:        Oni
        Prod version:   0.3.6
        File version:
        MachineType:    32-bit

or from Cygwin:

$ file /cygdrive/d/Setups/Oni-0.3.6-win.exe
/cygdrive/d/Setups/Oni-0.3.6-win.exe: PE32 executable (GUI) Intel 80386, for MS Windows

(should be PE32+ for 64-bit exe.)

The file from the zip (x64) link on the other hand does contain a 64 bit executable.

[oni-bot[bot]]

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

[CrossR]

Hey,

I think you are right, in that when I moved everything over I didn't update the Inno config (our installer package) to use the x64bit version.

The actual executables inside the 64bit version should be fine (ie Electron, Nvim, Ripgrep), its just we aren't installing it correctly.

@bryphe since we are doing some changes to the builds already (for the CLI installers, so install scripts and stuff will need to change for them), does it make sense for us to fix this before the next release?

We'd need to update the inno config as far as I know, which isn't a big deal, but I don't know if there is a nice way of us removing the 32bit install, or if we'd need to ask the user to remove the old one.