Closed akinsho closed 6 years ago
Wow, that looks amazing! :clap:
Merging #2527 into master will increase coverage by
0.08%
. The diff coverage is53.94%
.
@@ Coverage Diff @@
## master #2527 +/- ##
==========================================
+ Coverage 44.43% 44.51% +0.08%
==========================================
Files 351 351
Lines 14260 14302 +42
Branches 1862 1865 +3
==========================================
+ Hits 6336 6367 +31
- Misses 7697 7709 +12
+ Partials 227 226 -1
Impacted Files | Coverage Δ | |
---|---|---|
browser/src/UI/components/common.ts | 92.85% <ø> (ø) |
:arrow_up: |
browser/src/Services/Sessions/SessionManager.ts | 74.19% <0%> (+0.86%) |
:arrow_up: |
browser/src/Services/Metadata.ts | 35.29% <22.22%> (-11.77%) |
:arrow_down: |
browser/src/Plugins/Api/Oni.ts | 37.63% <50%> (+0.27%) |
:arrow_up: |
...ser/src/Editor/NeovimEditor/WelcomeBufferLayer.tsx | 55.39% <61.29%> (+1.47%) |
:arrow_up: |
...er/src/Editor/NeovimEditor/NeovimEditorCommands.ts | 11.76% <0%> (-0.18%) |
:arrow_down: |
browser/src/Services/Diagnostics.ts | ||
browser/src/Services/Diagnostics/index.ts | 39.02% <0%> (ø) |
|
browser/src/Services/Sessions/SessionsStore.ts | 33.33% <0%> (+3.57%) |
:arrow_up: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e612eb8...4a2b29e. Read the comment docs.
Functionally, loading sessions works great! I like the redesign too, but a few points:
Image for reference:
@CrossR thanks for having a look much appreciated 👍
re. the heading sizes I can increase those a bit for legibility re. the spacing the idea was to have some spacing but between them and a visible divider, with your current theme it seems less obvious, but either way the gap may be too big there (as always im on a 15' mac so not the same effect, ill add a max width so that box is never too big so you dont get the large gap)
@CrossR just tweaked the styles to reduce the overall size of the box, and increase the size of the headers, can you give it a try and let me know if its improved, locally the change is less obvious, also if the text is still to small can you see if tweaking you ui.fontSize
changes it.
(I realise the things I'm commenting on are just formatting changes, but just documenting it!)
@CrossR thanks for checking those I'll merge this and then open a smaller pr to fix up the other bits 👍
Based off of #2522 (that should go in first) this PR adds a section with the available sessions to the welcome screen as well as the ability to restore a session.
This PR also has an updated welcome screen design (I begged a colleague who is a UI designer for some ideas for this hopefully we didn't got in the wrong direction)