search

onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 299 forks source link

Fix for #2046 Autocomplete/Suggestions don't scroll #2529

Closed psxpaul closed 6 years ago

psxpaul commented 6 years ago

Potential fix for the issue described in #2046

codecov[bot] commented 6 years ago

Codecov Report

Merging #2529 into master will increase coverage by 0.24%. The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2529      +/-   ##
==========================================
+ Coverage   44.51%   44.76%   +0.24%     
==========================================
  Files         351      351              
  Lines       14302    14301       -1     
  Branches     1865     1865              
==========================================
+ Hits         6367     6402      +35     
+ Misses       7709     7673      -36     
  Partials      226      226
Impacted Files Coverage Δ
...rowser/src/Editor/NeovimEditor/NeovimPopupMenu.tsx 15.38% <0%> (+2.48%) :arrow_up:
.../src/Services/ContextMenu/ContextMenuComponent.tsx 82.69% <100%> (+45.19%) :arrow_up:
browser/src/UI/components/Arrow.tsx 76.19% <0%> (+19.04%) :arrow_up:
browser/src/UI/components/HighlightText.tsx 100% <0%> (+23.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5beff5f...c706b6b. Read the comment docs.

badosu commented 6 years ago

Fixes #1874 as well