codecov[bot]
commented
6 years ago Codecov Report
Merging #2545 into master will not change coverage. The diff coverage is
100%.
@@ Coverage Diff @@
## master #2545 +/- ##
=======================================
Coverage 44.79% 44.79%
=======================================
Files 352 352
Lines 14302 14302
Branches 1858 1858
=======================================
Hits 6407 6407
Misses 7669 7669
Partials 226 226| Impacted Files | Coverage Δ | |
|---|---|---|
| browser/src/Services/Menu/MenuComponent.tsx | 40% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 990859b...feef8e9. Read the comment docs.
@CrossR this fixes the issues raised after merging #2542 (can you give it a try when your free) - cherry picked a commit and some weird things happened (re. cause) -
~As a side note not sure what exactly to do about the
lesscomponents, as the longer we have these components not converted the harder it becomes to refactor as new contributor or collaborators end up tweaking things in those components so they become a little more entrenched there aren't many left but it might be worth holding off changes to affected components till the conversions are done or having some conversion be a part of changing those components 🤷♂️~I'll focus my next few PRs on converting all them over in small chunks