onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 299 forks source link

Custom theme #259

Closed TalAmuyal closed 7 years ago

TalAmuyal commented 7 years ago

TL;DR

Themes that aren't the defaultly supplied, don't work.

Details

In my regular Neovim work-flow I use the Solaraized (dark) color-scheme. For some reason, it doesn't work well on Oni (that is, it is very similar to deleting the colorscheme onedark part of the default configuration of Oni).

When trying to use some of Neovim's default color schemes on Oni, I understood that most of them (or all?) have little to no effect.

Does a color scheme for Oni need to be specialized in any way? Does anyone knows what I'm talking about or have a suggestion?

A side-by-side example is attached. screenshot from 2017-02-26 09-20-23

In each window, the Solaraized color-scheme is set.

Bretley commented 7 years ago

I use salaried dark, I'd suggest using nvm true color or term gui colors. I'll post my vimrc later if you can't get this resolved

On Feb 26, 2017 1:36 PM, "Tal Amuyal" notifications@github.com wrote:

TL;DR

Themes that aren't the defaultly supplied, don't work. Details

In my regular Neovim work-flow I use the Solaraized (dark) color-scheme. For some reason, it doesn't work well on Oni (that is, it is very similar to deleting the colorscheme onedark part of the default configuration of Oni).

When trying to use some of Neovim's default color schemes on Oni, I understood that most of them (or all?) have little to no effect.

Does a color scheme for Oni need to be specialized in any way? Does anyone knows what I'm talking about or have a suggestion?

A side-by-side example is attached. [image: screenshot from 2017-02-26 09-20-23] https://cloud.githubusercontent.com/assets/5097613/23342444/0893c5ba-fc63-11e6-998f-1e2ee3722da2.png

In each window, the Solaraized color-scheme is set.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/extr0py/oni/issues/259, or mute the thread https://github.com/notifications/unsubscribe-auth/AICBCUOLjFzLD5FxW0qzyMv8vtwfwMQLks5rgcYWgaJpZM4MMeJd .

TalAmuyal commented 7 years ago

This far, I've tried set termguicolors but didn't see any change. Would be nice if you could dig up the missing piece.

metalelf0 commented 7 years ago

Also make sure you have the following lines in your ~/.oni/config.json file:

    "prototype.editor.backgroundOpacity": 1,
    "prototype.editor.backgroundImageUrl": null,
    "prototype.editor.backgroundImageSize": null

This disables the default background image oni provides.

bryphe commented 7 years ago

Hmm, in theory it should work - but it looks like somehow solarized isn't being picked up by the neovim instance that we're using in Oni.

One question - where are you saving solarized? Are you saving it in your nvim\colors directory or are you using a plugin manager and saving it elsewhere?

In addition, the output of :set runtimepath in both the Oni and Neovim case would be helpful - we can compare and see if there is a runtimepath not being set when Oni is running, and then troubleshoot from there.

Bretley commented 7 years ago

give this a try

frankier/neovim-colors-solarized-truecolor-only

(Plugin manager of your choice)

along with

let $NVIM_TUI_ENABLE_TRUE_COLOR=1

and

set termguicolors

It works for me, ket me know how this goes

bryphe commented 7 years ago

Sounds like this has been addressed by PR #256 , so I'll close. Feel free to reopen if this wasn't fully addressed

TalAmuyal commented 7 years ago

Just tried replacing the color-scheme (sadly, left it to be the last test). Seems it works, though it has some small color differences...