onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 299 forks source link

Crash when triggering autocomplete #2591

Closed Prior99 closed 6 years ago

Prior99 commented 6 years ago

Oni Version: 0.3.6 Neovim Version (Linux only): 0.3.1 Operating System: Arch Linux

Issue:

Editor crashes ("Oh no! ...") when using autocompletion with RLS on a symbol from an external crate.

TypeError: this.props.text.split is not a function
in g in xt in div in bt in Connect(bt) in i in Et in div in styled.div in div in div in styled.div in div in styled.div in w in Connect(w) in kn in div in w in Connect(w) in div in div in div in jt in y in Connect(y) in i in div in div in N in div in div in div in t in div in B in div in div in w in Connect(w) in i in div in div in div in div in div in ThemeProvider in w in Connect(w) in i
TypeError: this.props.text.split is not a function
    at g.render (/opt/oni-bin/resources/app/lib/browser/vendor.bundle.js:643)
    at p (/opt/oni-bin/resources/app/lib/browser/vendor.bundle.js:1035)
    at beginWork (/opt/oni-bin/resources/app/lib/browser/vendor.bundle.js:1035)
    at i (/opt/oni-bin/resources/app/lib/browser/vendor.bundle.js:1035)
    at o (/opt/oni-bin/resources/app/lib/browser/vendor.bundle.js:1035)
    at x (/opt/oni-bin/resources/app/lib/browser/vendor.bundle.js:1035)
    at _ (/opt/oni-bin/resources/app/lib/browser/vendor.bundle.js:1035)
    at y (/opt/oni-bin/resources/app/lib/browser/vendor.bundle.js:1035)
    at g (/opt/oni-bin/resources/app/lib/browser/vendor.bundle.js:1035)
    at l (/opt/oni-bin/resources/app/lib/browser/vendor.bundle.js:1035)

Expected behavior:

Editor doesn't crash. It's okay if no autocompletions are available, but I might lose my work here.

Actual behavior:

Editor crashes.

Steps to reproduce:

  1. Install RLS (rustup component add rls-preview)
  2. Configure Oni to work with RLS:
    "language.rust.languageServer.command": "rustup",
    "language.rust.languageServer.arguments": ["run", "nightly", "rls"],
    "language.rust.languageServer.rootFiles": ["Cargo.toml"],
    "language.rust.completionTriggerCharacters": [".", ":"]
  3. Write a simple Rust file using an external crate
  4. Navigate cursor to symbol of external crate
  5. Press .
oni-bot[bot] commented 6 years ago

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

Prior99 commented 6 years ago

screenshot_2018-09-28_10-19-11

Prior99 commented 6 years ago

I put a $5 Bounty on this.

Prior99 commented 6 years ago

I just checked this on the current master and the issue occurs there, too.