onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 301 forks source link

[feature removal] Don't "git reset HEAD^" on a simple click on recent commits, please #2596

Open solsticedhiver opened 5 years ago

solsticedhiver commented 5 years ago

That's an horrible feature.

With no warning, and a simple click, and no visible feedback, one could git reset HEAD^ without warning.

Please, remove that feature from the vcs sidebar (git here)

oni-bot[bot] commented 5 years ago

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

CrossR commented 5 years ago

I think this was picked up as part of the initial implementation, and the decided route was to put it under a keybind (I made the same mistake of my first instinct being to click). Something like ctrl-u would be harder to hit, or potentially just having the action itself unbound so a user has to manually opt in to a keybind for it.