onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 299 forks source link

Unfinished(?) loading indicator. #2631

Open jordwalke opened 5 years ago

jordwalke commented 5 years ago

I'm not sure if this design was intentional but it seemed like a bug to me when I saw it, so maybe the aesthetics should be reconsidered if it's not actually a bug. The loading indicator has a background with a drop shadow but no background color. I've never seen that visual paradigm before so it was kind of distracting and felt unfinished.

screen shot 2018-10-13 at 3 57 44 pm

I think the loading indicator in general is pretty large here, and the fact that it has its own animation seems a bit distracting - especially when the modal is shown discretely without animation, and the loading indicator has its own animation - the contrast between the discrete and fluid happening simultaneously is jarring (I could be totally wrong - it could just be that the transparency is drawing more attention to it). But maybe something much more subdued is in order? A little faded spinning icon in the right part of the text input?