feltech commented 5 years ago

For languages that allow method overloads, where the same method name can be defined with different arguments (e.g. C++), the label of a completion may be duplicated in the completions list, but the detail should be different.
Hence use the detail field, if available, to disambiguate between completion items when updating them with the result of a completionItem/resolve.

feltech commented 5 years ago

An example from cquery (C++) completions

Before the fix - both completion items appear to be duplicates: oni_completion_detail_1 oni_completion_detail_2

With the fix the second "duplicate" item shows it's different signature: oni_completion_detail_fixed

codecov[bot] commented 5 years ago

Codecov Report

Merging #2633 into master will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2633      +/-   ##
==========================================
+ Coverage   45.33%   45.38%   +0.04%     
==========================================
  Files         361      361              
  Lines       14572    14576       +4     
  Branches     1913     1915       +2     
==========================================
+ Hits         6606     6615       +9     
+ Misses       7741     7737       -4     
+ Partials      225      224       -1

Impacted Files	Coverage Δ
browser/src/Services/Completion/CompletionStore.ts	`73.42% <100%> (+4.36%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca6a4d1...98084c8. Read the comment docs.

onivim / oni

Fix updating detailed completion for overloaded methods #2633

Codecov Report