search

onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 300 forks source link

Changing themes results in flashing, and theme doesn't get set #2664

Closed lukakerr closed 5 years ago

lukakerr commented 5 years ago

Oni Version: 0.3.7.6458 Neovim Version (Linux only): (i'm using neovim version 0.2.2 set with the "debug.neovimPath" key, not sure if it relevant) Operating System: macOS Mojave 10.14.1

Issue: Changing themes results in window flashing forever, and theme doesn't get set. A related bug is also that selecting the theme with the mouse (not the arrow keys) doesn't result in the flashing, but doesn't actually set the theme, it just closes the command pallet.

In the console I don't get any errors/warnings, but this is some of the output

bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2
bundle.js:1 [NeovimEditor] Colors changed: nord - background: #2e3440 foreground: #d8dee9
bundle.js:1 [NeovimEditor] Colors changed: gruvbox - background: #282828 foreground: #ebdbb2

A gif demonstrating the problem is shown below:

oni_c

Expected behavior: The theme should get set

Actual behavior: The theme doesn't get set, and the window flashes

Steps to reproduce:

  1. Open the command pallet with CMD+SHIFT+P
  2. Choose "Themes: Choose Theme"
  3. Select a theme using the arrow keys (not the cursor)
oni-bot[bot] commented 5 years ago

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

marcagba commented 5 years ago

Hello @lukakerr ! AFAICS, this bug seems to have already been reported here: #2470

CrossR commented 5 years ago

Since this looks the be covered already, I'll close this out! Cheers for reporting though, and to @marcagba for finding the duplicate!