search

onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 300 forks source link

Fix #2669 & #2396 - Failure to start Neovim on OSX 10.14 Mojave #2682

Closed bryphe closed 5 years ago

bryphe commented 5 years ago

Issue: Oni was hitting https://github.com/neovim/neovim/issues/9134 when launched from finder in OSX Mojave, causing Neovim not to load.

Defect: Prior to the fix in Neovim, if the LANG environment variable was not set in OSX, Neovim would crash. Resiliency on the Neovim side is added here: https://github.com/neovim/neovim/commit/57acfceabeb349377ce244de9b67732b21ed1d18

Fix: For now - we'll just set a default (overridable) value in the case where LANG is not set. Once we pick up the 0.3.2 binaries, we won't need that anymore.

Fixes #2669 & #2396

codecov[bot] commented 5 years ago

Codecov Report

Merging #2682 into master will decrease coverage by <.01%. The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2682      +/-   ##
==========================================
- Coverage   45.78%   45.78%   -0.01%     
==========================================
  Files         361      361              
  Lines       14630    14634       +4     
  Branches     1924     1926       +2     
==========================================
+ Hits         6699     6700       +1     
- Misses       7701     7703       +2     
- Partials      230      231       +1
Impacted Files Coverage Δ
...src/Services/Configuration/DefaultConfiguration.ts 87.5% <ø> (ø) :arrow_up:
browser/src/Plugins/Api/Process.ts 52.63% <25%> (-1.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c1ef98...819e30c. Read the comment docs.